gianm commented on pull request #11965: URL: https://github.com/apache/druid/pull/11965#issuecomment-974898345
The issue is that the behavior of wikipedia_index_task.json is order-dependent with regard to its input files; some orders produce 4 segments and some produce 5 segments. Some integration tests, like ITSystemTableBatchIndexTaskTest and ITAutoCompactionTest, are written assuming that the 4-segment case will always happen. Providing the file list in a specific order ensures that this will happen as expected by the tests. In the patch, I did this in part by making LocalInputSource.files parameter a List instead of a Set, since I didn't see a reason why it needed to be a Set. Being a List is also consistent with the behavior of other input sources like S3, GCS, HTTP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
