loquisgon commented on a change in pull request #11941:
URL: https://github.com/apache/druid/pull/11941#discussion_r755434975
##########
File path:
extensions-core/s3-extensions/src/test/java/org/apache/druid/data/input/s3/S3InputSourceTest.java
##########
@@ -535,6 +539,48 @@ public void testReader() throws IOException
EasyMock.verify(S3_CLIENT);
}
+ @Test(expected = SdkClientException.class)
+ public void
testReaderRetriesOnSdkClientExceptionButNeverSucceedsThenThrows() throws
Exception
Review comment:
Done. It is kind of ugly though due to the global nature of
`RetryUtils#DEFAULT_MAX_TRIES` and its pervasive use throughout the code . In
general I think we should avoid having static constants .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
