clintropolis commented on a change in pull request #11184:
URL: https://github.com/apache/druid/pull/11184#discussion_r759805795
##########
File path:
core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java
##########
@@ -385,7 +322,59 @@ protected BinaryOpExprBase copy(Expr left, Expr right)
public ExprEval eval(ObjectBinding bindings)
{
ExprEval leftVal = left.eval(bindings);
- return leftVal.asBoolean() ? right.eval(bindings) : leftVal;
+ if (!ExpressionProcessing.useStrictBooleans()) {
Review comment:
yeah, this is how most of the non-vectorized processing is currently, it
would be possible with some refactoring I think to make specialized
implementations for various cases, but we've been mainly focusing on doing that
where possible in the vectorized expression processing, since operating on
batches is significantly faster and has less overhead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
