jihoonson commented on a change in pull request #12012:
URL: https://github.com/apache/druid/pull/12012#discussion_r761551812
##########
File path: services/src/main/java/org/apache/druid/cli/GuiceRunnable.java
##########
@@ -56,23 +63,57 @@ public GuiceRunnable(Logger log)
public abstract void run();
@Inject
- public void configure(Injector injector)
+ public void configure(Properties properties, Injector injector)
Review comment:
`getNodeRoles` is defined in `ServerRunnable` which is a child class of
`GuiceRunnable`. I think it makes more sense to have it there as
`ServerRunnable` specifically represents servers while `GuiceRunnable` can be
any runnable that uses Guice injection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
