zachjsh opened a new pull request #12021:
URL: https://github.com/apache/druid/pull/12021
### Description
This PR fixes an issue in which if a lookup is configured incorreclty; does
not serialize properly when being pulled by peon node, it causes the task to
fail. The failure occurs because the peon and other leaf nodes (broker,
historical), have retry logic that continues to retry the lookup loading for 3
minutes by default. The http listener thread on the peon task is not started
until lookup loading completes, by default, the overlord waits 1 minute by
default, to communicate with the peon task to get the task status, after which
is orders the task to shut down, causing the ingestion task to fail.
To fix the issue, we catch the exception serialization error, and do not
retry. Also fixed an issue in which a bad lookup config interferes with any
other good lookup configs from being loaded.
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
