clintropolis opened a new pull request #12023: URL: https://github.com/apache/druid/pull/12023
### Description The documentation specifies that using a `timeout` of `0`, however this was actually a lie and specifying a timeout of 0 would cause a query to timeout and fail immediately. This PR fixes this issue, but also doesn't completely allow infinite timeout to be totally within the users control (with no way for the server-side to mitigate) so instead allows 0 to use the maximum server-side timeout `druid.server.http.maxQueryTimeout`, which defaults to `Long.MAX_VALUE` so is effectively unlimited unless explicitly configured by operators. <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [x] been self-reviewed. - [x] added documentation for new or modified features or behaviors. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
