clintropolis commented on a change in pull request #12025:
URL: https://github.com/apache/druid/pull/12025#discussion_r763320122
##########
File path:
processing/src/main/java/org/apache/druid/segment/DimensionSelector.java
##########
@@ -164,6 +166,27 @@ static DimensionSelector constant(@Nullable final String
value, @Nullable final
}
}
+ static DimensionSelector multiConstant(@Nullable final List<String> values)
+ {
+ if (values == null || values.isEmpty()) {
+ return NullDimensionSelectorHolder.NULL_DIMENSION_SELECTOR;
+ } else {
+ return new ConstantMultiValueDimensionSelector(values);
+ }
+ }
+
+ static DimensionSelector multiConstant(@Nullable final List<String> values,
@Nullable final ExtractionFn extractionFn)
+ {
+ if (extractionFn == null) {
+ return multiConstant(values);
+ } else {
+ if (values == null) {
+ return constant(extractionFn.apply(null));
Review comment:
i originally had it like that, but am unsure if `null` and `[null]` are
_actually_ the same thing. From the perspective of grouping, they are identical
I guess so it probably doesn't matter. To me the most correct thing would be to
_not_ apply the extraction at all and just make it a constant null and not a
list with a null, but those are sort of the same thing for string columns
currently...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
