wjhypo commented on a change in pull request #11309:
URL: https://github.com/apache/druid/pull/11309#discussion_r764462889
##########
File path:
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java
##########
@@ -369,7 +392,7 @@ private void addSegments(Collection<DataSegment> segments,
final DataSegmentChan
numSegments,
segment.getId()
);
- loadSegment(segment, callback, config.isLazyLoadOnStart());
+ loadSegment(segment, callback, config.isLazyLoadOnStart(),
loadSegmentsIntoPageCacheOnBootstrapExec);
Review comment:
@pjain1 Hi Parag, sorry about the delay. Sorry I still didn't get time
to make the change and verify the sync approach in a test cluster. Not sure if
any user is in need of the sync approach. We only verified the async approach
in production. At this point, it would be better if someone in need of the sync
approach can help make the change and dedicate some time to verify the change.
It currently doesn't align with our priority at work so I won't be able to make
the change this year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
