abhishekagarwal87 commented on a change in pull request #12033:
URL: https://github.com/apache/druid/pull/12033#discussion_r764614500
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java
##########
@@ -3122,23 +3121,8 @@ public void
testInnerJoinOnTwoInlineDataSources_withLeftDirectAccess(Map<String,
@Parameters(source = QueryContextForJoinProvider.class)
public void testJoinOnConstantShouldFail(Map<String, Object> queryContext)
throws Exception
{
- cannotVectorize();
-
- final String query = "SELECT t1.dim1 from foo as t1 LEFT JOIN foo as t2 on
t1.dim1 = '10.1'";
-
- try {
- testQuery(
- query,
- queryContext,
- ImmutableList.of(),
- ImmutableList.of()
- );
- }
- catch (RelOptPlanner.CannotPlanException cpe) {
- Assert.assertEquals(cpe.getMessage(), "Possible error: SQL is resulting
in a join that have unsupported operand types.");
- return;
- }
- Assert.fail("Expected an exception of type: " +
RelOptPlanner.CannotPlanException.class);
+ assertQueryIsUnplannable("SELECT t1.dim1 from foo as t1 LEFT JOIN foo as
t2 on t1.dim1 = '10.1'",
+ "Possible error: SQL is resulting in a join that have unsupported
operand types.");
Review comment:
agreed. will fix that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
