LakshSingla commented on a change in pull request #11923:
URL: https://github.com/apache/druid/pull/11923#discussion_r766533412
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidLogicalValuesRule.java
##########
@@ -93,24 +94,28 @@ public void onMatch(RelOptRuleCall call)
*
* @throws IllegalArgumentException for unsupported types
*/
+ @Nullable
@VisibleForTesting
static Object getValueFromLiteral(RexLiteral literal, PlannerContext
plannerContext)
{
+ if (RexLiteral.value(literal) == null) {
Review comment:
We do need the null check since that is getting activated in the test
cases. Maybe it can be put in the respective switch case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
