zachjsh commented on a change in pull request #12052:
URL: https://github.com/apache/druid/pull/12052#discussion_r768046445
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
##########
@@ -413,6 +420,10 @@ protected boolean tryTimeChunkLock(TaskActionClient
client, List<Interval> inter
if (lock.isRevoked()) {
throw new ISE(StringUtils.format("Lock for interval [%s] was
revoked.", cur));
}
+ locksAcquired++;
+ if (maxAllowedLockCount >= 0 && locksAcquired > maxAllowedLockCount) {
Review comment:
Should we move this above where we submit request for lock, and check
`locksAcquired + 1 > maxAllowedLockCount`
? At this point, I think we would have exceeded the maxCount by 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
