paul-rogers edited a comment on pull request #12058:
URL: https://github.com/apache/druid/pull/12058#issuecomment-995327640


   One of the steps failed in a unit test which appears due to flaky behavior:
   
   ```text
   [ERROR] 
testReconnectWithCacheAndPrefetch(org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest)
  Time elapsed: 8.224 s  <<< ERROR!
   java.lang.RuntimeException: java.util.concurrent.TimeoutException
        at 
org.apache.druid.data.input.impl.prefetch.Fetcher.openObjectFromLocal(Fetcher.java:226)
        at 
org.apache.druid.data.input.impl.prefetch.Fetcher.next(Fetcher.java:177)
        at 
org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactory$2.next(PrefetchableTextFilesFirehoseFactory.java:239)
        at 
org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactory$2.next(PrefetchableTextFilesFirehoseFactory.java:225)
        at 
org.apache.druid.data.input.impl.FileIteratingFirehose.getNextLineIterator(FileIteratingFirehose.java:105)
        at 
org.apache.druid.data.input.impl.FileIteratingFirehose.hasMore(FileIteratingFirehose.java:66)
        at 
org.apache.druid.data.input.impl.prefetch.PrefetchableTextFilesFirehoseFactoryTest.testReconnectWithCacheAndPrefetch(PrefetchableTextFilesFirehoseFactoryTest.java:356)
   ```
   
   The same test passed in the "SQL compatibility" test, and on my machine in 
both Maven and the IDE. So, the test is flaky.
   
   Took a look a the test. The Firehose is completely separate from any of the 
areas I changed. Perhaps there is a race condition in the code, though brief 
inspection did not reveal the cause. Anyone seen this one fail previously? 
Added more detail to the exception in case if fails again. Let's not hold up 
reviews due to this test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to