jihoonson opened a new pull request #12095:
URL: https://github.com/apache/druid/pull/12095
### Description
Currently, our integration test uses maven to pull in dependencies for some
extensions instead of Druid's extension loading system. The discrepancy in how
Druid loads extension dependencies between in production and in integration
tests makes our integration tests less trust-able. This PR fixes it to use
Druid's extension system for every extension.
This PR also cleans up a bit how integration test configuration system
works.
- Before this PR, some integration tests use a fixed loadList that is set in
`setupData` in `druid.sh`. This loadList is not overrideable which is confusing
and also hard to debug. This PR removes the fixed loadList.
- This PR also removes unnecessary docker compose settings for
`custom-coordinator-duties` and `shuffle-deep-store` groups. The docker compose
setting should be used only when the test group requires for extra nodes to run
besides the default nodes defined in `docker-compose.yml` or
`docker-compose.override-env.yml`.
<hr>
##### Key changed/added classes in this PR
* `copy_resources_template.sh`
* `druid.sh`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
