LakshSingla commented on a change in pull request #12092:
URL: https://github.com/apache/druid/pull/12092#discussion_r777480523



##########
File path: 
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidLogicalValuesRule.java
##########
@@ -128,6 +128,11 @@ static Object getValueFromLiteral(RexLiteral literal, 
PlannerContext plannerCont
       case TIMESTAMP:
       case DATE:
         return Calcites.calciteDateTimeLiteralToJoda(literal, 
plannerContext.getTimeZone()).getMillis();
+      case NULL:

Review comment:
       Got it, thanks. I was incorrectly assuming that this was aimed at making 
the error message more specific to null columns. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to