paul-rogers opened a new pull request #12115:
URL: https://github.com/apache/druid/pull/12115
### Description
Several changes to better support extension services:
* Use Guice to publish the list of known node roles so an extension can add
to it.
* Use the Guice list in for SQL servers system table so it will publish
instances of the extension service.
* Split out the index task client into a base class to allow the client to
be used for an extension service.
* Add a PrivateApi annotation to mark REST services primarily used
internally to the server.
* Misc. code cleanup.
<hr>
##### Key changed/added classes in this PR
* `NodeRoles` - A Guice multi-binder to hold the list of Druid- and
extension-defined node roles.
* `PrivateAPI` - Annotation to use to mark a REST service which is private
to a server rather than being public. Such private APIs should not be
documented.
* `TaskClient` - Holds most of what was in `IndexTaskClient`, but without
the tight binding to the indexer. `IndexTaskClient` now extends `TaskClient`
and adds the Indexer-specific assumptions.
<hr>
This PR has:
- [X] been self-reviewed.
- [X] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [X] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [X] been tested via the Maven build and the tests run in Github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
