xvrl commented on a change in pull request #12032:
URL: https://github.com/apache/druid/pull/12032#discussion_r778504064
##########
File path:
core/src/main/java/org/apache/druid/java/util/http/client/NettyHttpClient.java
##########
@@ -355,30 +355,31 @@ public void channelDisconnected(ChannelHandlerContext
context, ChannelStateEvent
private void removeHandlers()
{
if (readTimeout > 0) {
- channel.getPipeline().remove(READ_TIMEOUT_HANDLER_NAME);
+ channel.pipeline().remove(READ_TIMEOUT_HANDLER_NAME);
}
- channel.getPipeline().remove(LAST_HANDLER_NAME);
+ channel.pipeline().remove(LAST_HANDLER_NAME);
}
}
);
- channel.write(httpRequest).addListener(
- new ChannelFutureListener()
- {
- @Override
- public void operationComplete(ChannelFuture future)
- {
- if (!future.isSuccess()) {
- channel.close();
- channelResourceContainer.returnResource();
- if (!retVal.isDone()) {
- retVal.setException(
- new ChannelException(
- StringUtils.format("[%s] Failed to write request to
channel", requestDesc),
- future.getCause()
- )
- );
- }
+ channel.write(httpRequest);
+ if (request.hasContent()) {
+ channel.write(new DefaultHttpContent(request.getContent()));
Review comment:
it looks like there is `FullHttpRequest`, which implements both
HttpRequest and LastHttpContent, and should be transparent to the HTTP encoder,
so we could use that instead to avoid multiple messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
