clintropolis opened a new pull request #12155:
URL: https://github.com/apache/druid/pull/12155


   This PR reverts a change made semi recently that causes potentially subtly 
incorrect `ColumnInspector` to be used in a `RowBasedColumnSelectorFactory` in 
`IncrementalIndex`. The schema of the `IncrementalIndex` doesn't necessarily 
match the schema of the `InputRow`, which was my mistake.
   
   Ideally, the InputRow could provide its signature so that the stuff using 
this column selector factory could have better information, but i'll save that 
for another day.
   
   It isn't immediately obvious to me the best way to add a direct test for 
this, will add to PR if i think of one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to