AmatyaAvadhanula commented on a change in pull request #12161:
URL: https://github.com/apache/druid/pull/12161#discussion_r785698866
##########
File path:
integration-tests/src/main/java/org/apache/druid/testing/utils/KinesisAdminClient.java
##########
@@ -119,13 +126,14 @@ public void updatePartitionCount(String streamName, int
newShardCount, boolean b
// Wait until the resharding started (or finished)
ITRetryUtil.retryUntil(
() -> {
- StreamDescription streamDescription =
getStreamDescription(streamName);
- int updatedShardCount = getStreamShardCount(streamDescription);
- return verifyStreamStatus(streamDescription,
StreamStatus.UPDATING) ||
- (verifyStreamStatus(streamDescription, StreamStatus.ACTIVE) &&
updatedShardCount > originalShardCount);
+ String streamStatus = getStreamStatus(streamName);
+ int updatedShardCount = getStreamPartitionCount(streamName);
+ return (streamStatus.equals(StreamStatus.UPDATING.toString()) ||
+ streamStatus.equals(StreamStatus.ACTIVE.toString()))
Review comment:
Yes, it is intentional to account for the scenarios where the stream
itself might have been in updating state due to some other operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
