uschindler commented on pull request #12170:
URL: https://github.com/apache/druid/pull/12170#issuecomment-1016786812
Thanks. The other `ignoreSignaturesOfMissingClasses` is still enabled, as
otherwise ICU checks fail on some subprojects not including ICU.
Maybe in future the same should be done: Have a separate file only with ICU
signatures and just add them on subprojects where ICU is actually used. One way
to do this is (according to Maven doc, untested):
```xml
<signaturesFiles combine.children="append">
<signaturesFile>path/to/icu-signatures.txt</directory>
</signaturesFiles>
```
This would add the signaturesFile to the ones inherited from parent. This is
useful for lists. Unfortunately there's no way to remove some from the parent
list - this is why I needed to replcate the whole config in the current PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
