clintropolis commented on a change in pull request #12194:
URL: https://github.com/apache/druid/pull/12194#discussion_r791167301
##########
File path:
processing/src/main/java/org/apache/druid/segment/ColumnProcessors.java
##########
@@ -342,7 +342,7 @@ private static ColumnCapabilities
computeDimensionSpecCapabilities(
);
}
- if (mayBeMultiValue(capabilities)) {
+ if (capabilities.hasMultipleValues().isMaybeTrue()) {
Review comment:
there isn't really anything to be shared here,
`StringAnyAggregatorFactory` needs a null check (different from this shared
method since it is only applicable to non-vectorized engines) while this part
of the code has already checked null, so I think the shared method would only
really be used by `StringAnyAggregatorFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
