jihoonson commented on a change in pull request #12187:
URL: https://github.com/apache/druid/pull/12187#discussion_r791208409
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -65,7 +65,8 @@
/**
* If true {@link KillUnusedSegments} sends kill tasks for unused segments
in all data sources.
*/
- private final boolean killUnusedSegmentsInAllDataSources;
+ @Nullable
+ private final Boolean killUnusedSegmentsInAllDataSources;
Review comment:
nit: can we compute its default per the given `killDataSourceWhitelist`
instead of making it nullable? It could simplify the code a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
