LakshSingla commented on a change in pull request #12163:
URL: https://github.com/apache/druid/pull/12163#discussion_r793952013
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java
##########
@@ -744,18 +755,28 @@ public T next()
private SqlNode query;
- private ParsedNodes(@Nullable SqlExplain explain, @Nullable SqlInsert
insert, SqlNode query)
+ @Nullable
+ private String ingestionGranularity;
+
+ private ParsedNodes(
+ @Nullable SqlExplain explain,
+ @Nullable SqlInsert insert,
Review comment:
Yep, your understanding of the code is correct. That is we always hit
our DruidSqlInsert production rule, irrespective of whether we have a simple
INSERT or the one containing clauses. But just to ensure that I wasn't breaking
anything that already existed while prototyping (and this overshadowing of the
custom rule is not seen in the code), I am simply returning the SqlInsert
statement in case both partition and cluster clauses are empty.
Since replacing SqlInsert with DruidSqlInsert seems to be a better approach,
I think we can remove separate handling of SqlInsert and DruidSqlInsert (and
make the corresponding changes in the production rule)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
