LakshSingla commented on a change in pull request #12163: URL: https://github.com/apache/druid/pull/12163#discussion_r794787048
########## File path: sql/src/main/codegen/includes/insert.ftl ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +SqlNode DruidSqlInsert() : +{ + SqlNode insertNode; + SqlNode partitionBy = null; + SqlNodeList clusterBy = null; +} +{ + insertNode = SqlInsert() + [ + <PARTITION> <BY> + partitionBy = StringLiteral() Review comment: If I had to pick, 2 seems like a cleaner option. While 1 is implemented right now, quoting and adding a literal doesn't seem pretty, given that we have a fixed range of what can go in front of a `PARTITIONED BY`. 3 seems a bit more verbose, and to me, it implies that a) I can use a column other than `__time` b) I can use an expression other than `FLOOR`. However, I am unfamiliar with the other databases which implement the syntax in this manner and therefore of the conventions when it comes to `PARTITIONED BY`, hence I am using this convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
