machine424 commented on issue #12197: URL: https://github.com/apache/druid/issues/12197#issuecomment-1025143613
Hello, I've done some digging and I came across this: We first set the absolute timeout like this: https://github.com/apache/druid/blob/ef006fd2571228984b04b95f3a3e2b03d930dce3/processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java#L94-L97 But we keep shrinking it here: https://github.com/apache/druid/blob/ef006fd2571228984b04b95f3a3e2b03d930dce3/processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java#L190-L194 I don't understand why, especially that the timeout check is: https://github.com/apache/druid/blob/ef006fd2571228984b04b95f3a3e2b03d930dce3/processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java#L176-L178 Am I missing something? After commenting out `Lines 190 to 194`, the query's `timeout` (As I understand it) seems to be respected. Of course it's always possible to exceed it (while in `rowsToList` for example if the `batchSize` is big) but this is another subject which is discussed in https://github.com/apache/druid/issues/1415. Maybe @jihoonson -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
