rohangarg opened a new pull request #12225:
URL: https://github.com/apache/druid/pull/12225
Currently, the feature flag 'enableRewriteJoinToFilter' tries to rewrite a
join as a filter when possible in inner joins. A correctness condition to do
that rewrite requires all the keys on the build/right side of the join to be
unique (since join would add multiplicity for duplicate keys).
If the values contain duplicates, we can still push them as filters but
along with retaining the original join so that the correctness of results is
maintained. This will help in reducing the data read by the system (when bitmap
filtering is used) and also in less computation (the filtering is pushed below
the join and even further whenever possible).
TODO : add tests for the new method in JoinableFactoryWrapper
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
