nishantmonu51 commented on a change in pull request #12198:
URL: https://github.com/apache/druid/pull/12198#discussion_r798231766
##########
File path:
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitter.java
##########
@@ -77,12 +80,28 @@ public void start()
} else {
log.error("HTTPServer is already started");
}
- } else if (strategy.equals(PrometheusEmitterConfig.Strategy.pushgateway)) {
- pushGateway = new PushGateway(config.getPushGatewayAddress());
+ } else if (strategy.equals(PrometheusEmitterConfig.Strategy.pushgateway)
&& config.getPushGatewayAddress() != null) {
Review comment:
Nit: can we move this check as a Precondition check in
PrometheusEmitterConfig for the case when strategy is set to pushGateway but
the gateway address is null ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
