suneet-s commented on a change in pull request #12231:
URL: https://github.com/apache/druid/pull/12231#discussion_r799106478



##########
File path: docs/configuration/index.md
##########
@@ -1783,10 +1782,9 @@ The broker uses processing configs for nested groupBy 
queries.
 |Property|Description|Default|
 |--------|-----------|-------|
 |`druid.processing.buffer.sizeBytes`|This specifies a buffer size (less than 
2GiB) for the storage of intermediate results. The computation engine in both 
the Historical and Realtime processes will use a scratch buffer of this size to 
do all of their intermediate computations off-heap. Larger values allow for 
more aggregations in a single pass over the data while smaller values can 
require more passes depending on the query that is being executed. 
[Human-readable format](human-readable-byte.md) is supported.|auto (max 1GiB)|
+|`druid.processing.buffer.poolCacheInitialCount`|initializes the number of 
buffers allocated on the intermediate results pool. Note that pool can create 
more buffers if necessary.|`0`|
 |`druid.processing.buffer.poolCacheMaxCount`|processing buffer pool caches the 
buffers for later use, this is the maximum count cache will grow to. note that 
pool can create more buffers than it can cache if necessary.|Integer.MAX_VALUE|
-|`druid.processing.formatString`|Realtime and Historical processes use this 
format string to name their processing threads.|processing-%s|
 |`druid.processing.numMergeBuffers`|The number of direct memory buffers 
available for merging query results. The buffers are sized by 
`druid.processing.buffer.sizeBytes`. This property is effectively a concurrency 
limit for queries that require merging buffers. If you are using any queries 
that require merge buffers (currently, just groupBy v2) then you should have at 
least two of these.|`max(2, druid.processing.numThreads / 4)`|

Review comment:
       I had considered changing the default here to 2 since I removed the 
reference to druid.processing.numThreads. However, that seemed like it could be 
problematic for users who set `druid.processing.numThreads` previously and are 
upgrading to this version.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to