AmatyaAvadhanula commented on a change in pull request #12235:
URL: https://github.com/apache/druid/pull/12235#discussion_r801729689
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java
##########
@@ -750,6 +752,25 @@ public boolean isAnyFetchActive()
.anyMatch(fetch -> (fetch != null &&
!fetch.isDone()));
}
+ /**
+ * Is costly and requires polling the shard to determine if it's empty
+ * @param stream to which shard belongs
+ * @param shardId of the shard
+ * @return if the shard is empty
+ */
+ public boolean isShardEmpty(String stream, String shardId)
Review comment:
Yes, will rename it to isClosedShardEmpty, like it is in
KinesisSupervisor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
