somu-imply opened a new pull request #12254:
URL: https://github.com/apache/druid/pull/12254
Added vectorization for time_shift functionality by overloading the
canVectorize and buildVectorized methods. Test cases added to improve coverage
in processing module as well as benchmarking tests added which shows a minimum
of 15% to a maximum of 75% improvement across different distributions and
cardinalities. For reference these are the distributions and cardinalities for
the benchmarking tests.
```
33 -> sequential
34 -> zipf low cardinality
35 -> zipf high cardinality
36 -> uniform low cardinality
37 -> uniform high cardinality
```
The results are
```
Benchmark (query) (rowsPerSegment) (vectorize)
Mode Cnt Score Error Units
SqlExpressionBenchmark.querySql 33 5000000 false
avgt 5 3420.793 ± 124.984 ms/op
SqlExpressionBenchmark.querySql 33 5000000 force
avgt 5 2046.367 ± 67.303 ms/op
SqlExpressionBenchmark.querySql 34 5000000 false
avgt 5 1040.446 ± 31.264 ms/op
SqlExpressionBenchmark.querySql 34 5000000 force
avgt 5 262.247 ± 5.442 ms/op
SqlExpressionBenchmark.querySql 35 5000000 false
avgt 5 986.067 ± 36.386 ms/op
SqlExpressionBenchmark.querySql 35 5000000 force
avgt 5 286.723 ± 4.506 ms/op
SqlExpressionBenchmark.querySql 36 5000000 false
avgt 5 4481.296 ± 200.415 ms/op
SqlExpressionBenchmark.querySql 36 5000000 force
avgt 5 3017.560 ± 122.837 ms/op
SqlExpressionBenchmark.querySql 37 5000000 false
avgt 5 13163.827 ± 457.703 ms/op
SqlExpressionBenchmark.querySql 37 5000000 force
avgt 5 11264.443 ± 336.447 ms/op
```
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
