cryptoe commented on a change in pull request #12267:
URL: https://github.com/apache/druid/pull/12267#discussion_r811336728
##########
File path:
extensions-core/protobuf-extensions/src/main/java/org/apache/druid/data/input/protobuf/ProtobufReader.java
##########
@@ -88,7 +89,7 @@
{
Map<String, Object> record;
- if (flattenSpec == null) {
+ if (flattenSpec == null || JSONPathSpec.DEFAULT.equals(flattenSpec)) {
Review comment:
So if flattenSpec is set to the default value, in the new flow non root
fields are also coming which is expected. Checkout :
https://www.javadoc.io/doc/com.google.protobuf/protobuf-java/3.11.0/com/google/protobuf/DynamicMessage.html
```
Returns a collection of all the fields in this message which are set and
their corresponding values.
```
One approach is to document this behavior for proto readers namely non root
fields are also part of the row when the above payload is present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
