paul-rogers commented on a change in pull request #12223:
URL: https://github.com/apache/druid/pull/12223#discussion_r812158085
##########
File path: processing/src/main/java/org/apache/druid/query/Druids.java
##########
@@ -869,6 +860,16 @@ public ScanQueryBuilder intervals(QuerySegmentSpec q)
return this;
}
+ /**
+ * Convenience method for an interval over all time.
+ */
+ public ScanQueryBuilder eternity()
Review comment:
Naming is hard! This particular builder uses short names for the key
thing to be changed: `intervals`, `context`, etc. Since "eternity" is an
interval, the name `eternity` seems to fit the succinct naming pattern used in
this class.
I see the point that the other methods take an argument. One can imagine
that this method takes the necessary argument for an interval over all time,
but there are no necessary arguments.
An analogy would be that, if we often used
`resultFormat(ResultFormat.VALUE_VECTOR)`, we might add a `valueVector()`
method.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
