AlexanderSaydakov commented on a change in pull request #12224:
URL: https://github.com/apache/druid/pull/12224#discussion_r817269308
##########
File path:
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildBufferAggregatorHelper.java
##########
@@ -123,7 +126,8 @@ public int getLgK()
private WritableMemory getMemory(final ByteBuffer buf)
{
- return memCache.computeIfAbsent(buf, b -> WritableMemory.writableWrap(b,
ByteOrder.LITTLE_ENDIAN));
+ return memCache.computeIfAbsent(buf,
+ b -> WritableMemory.writableWrap(b, ByteOrder.LITTLE_ENDIAN,
MEM_REQ_SERVER));
Review comment:
Unit tests were added to make sure this support works. If you look at
the changes, you can see that I changed a few tests from asserting failure to
asserting success. For instance testFailureWhenMaxStreamLengthHit to
testSuccessWhenMaxStreamLengthHit in DoublesSketchAggregatorTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
