clintropolis commented on pull request #12251: URL: https://github.com/apache/druid/pull/12251#issuecomment-1057972359
I have confirmed this change is safe for min/max aggregators, which have special logic when using the `expression` field that only impacts STRING and ARRAY typed expressions when `druid.generic.useDefaultValueForNull=false`, but the SQL planner would have never planned such a thing, as it would have inferred the min/max aggregator to be string typed - which doesn't exist, and so would instead fail with `Possible error: Max aggregation is not supported for 'STRING' type`. added a couple of additional tests from this investigation, just to document inconsistencies in behavior. It also appears that the "string wrappers" that the numeric aggregators use, `StringColumnDoubleAggregatorWrapper`, etc, do not behave correctly in SQL compatible null handling mode (`druid.generic.useDefaultValueForNull=false`), but i didn't modify them in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
