cchanyi opened a new pull request #12301: URL: https://github.com/apache/druid/pull/12301
Fixes #10364 ### Description The method getPMF in DoublesSketch performs a sort operation when the number of split points is greater than 50. It looks like the sort is for performance reasons and if it changes the memory, will generate this error in a query: ``` Error: Unknown exception MemoryImpl is read-only. org.apache.datasketches.memory.ReadOnlyException ``` This is because the `deserialize` methods currently wrap with read-only memory. Modified the method to use `WritableMemory.writableWrap` when deserializing from byte array. <hr> This PR has: - [x ] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
