jasonk000 opened a new pull request #12302:
URL: https://github.com/apache/druid/pull/12302


   ### Description
   
   Use a smaller default buffer in the TextReader during parsing. By default, 
the [LineIterator creates a BufferedReader if one is not 
provided](https://github.com/apache/commons-io/blob/master/src/main/java/org/apache/commons/io/LineIterator.java#L84-L88);
 the default [BufferedReader creates an 8KB 
buffer](https://github.com/AdoptOpenJDK/openjdk-jdk8u/blob/9a751dc19fae78ce58fb0eb176522070c992fb6f/jdk/src/share/classes/java/io/BufferedReader.java#L88).
 This is unnecessary for most parsing.
   
   Improve this by creating our own BufferedReader with a custom line length.
   
   ### Questions
   
   - Should this be configurable?
   
   ### Checklist
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to