maytasm commented on a change in pull request #12299:
URL: https://github.com/apache/druid/pull/12299#discussion_r819960643



##########
File path: 
server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java
##########
@@ -483,6 +505,28 @@ public boolean isShowServlet()
           return false;
         }
 
+
+        @Override
+        public void generateAcceptableResponse(
+            Request baseRequest,
+            HttpServletRequest request,
+            HttpServletResponse response,
+            int code,
+            String message,
+            String contentType
+        ) throws IOException
+        {
+          if (config.isDefaultJettyErrorResponseInJson()) {

Review comment:
       Regardless of what the new config is set to, we should always use the 
Accept header to determine the response format right? The new config should 
only apply when the Accept header is not given. This is to maintain backward 
compatibility with current behavior when this config is not set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to