gianm commented on a change in pull request #12309: URL: https://github.com/apache/druid/pull/12309#discussion_r821199014
########## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/DictionaryBuilding.java ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.groupby.epinephelinae; + +import it.unimi.dsi.fastutil.objects.Object2IntMap; +import it.unimi.dsi.fastutil.objects.Object2IntOpenHashMap; + +import java.util.ArrayList; +import java.util.List; + +/** + * Utilities for parts of the groupBy engine that need to build dictionaries. + */ +public class DictionaryBuilding +{ + public static final int UNKNOWN_DICTIONARY_ID = -1; Review comment: I switched to DimensionDictionary.ABSENT_VALUE_ID. ########## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/column/DictionaryBuildingStringGroupByColumnSelectorStrategy.java ########## @@ -44,13 +44,11 @@ { private static final int GROUP_BY_MISSING_VALUE = -1; - private int nextId = 0; - private final List<String> dictionary = new ArrayList<>(); - private final Object2IntOpenHashMap<String> reverseDictionary = new Object2IntOpenHashMap<>(); + // Entry in dictionary, node pointer in reverseDictionary, hash + k/v/next pointer in reverseDictionary nodes + public static final int ROUGH_OVERHEAD_PER_DICTIONARY_ENTRY = Long.BYTES * 5 + Integer.BYTES; Review comment: yep, it is. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
