clintropolis opened a new pull request #12323:
URL: https://github.com/apache/druid/pull/12323


   
   ### Description
   
   Improves the performance of `FileWriteOutBytes.readFully` by using the 
tracked byte size added in #9722, instead of calling the channel size() method, 
which ends up in a native syscall to check the size of the file on disk. This 
`readFully` method is used by `GenericIndexedWriter.get` which is currently 
only used when merging spatial indexes, but would be an improvement for 
anything looking to read stuff out of the channel.
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to