somu-imply commented on a change in pull request #12320:
URL: https://github.com/apache/druid/pull/12320#discussion_r826354698
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/mean/DoubleMeanVectorAggregator.java
##########
@@ -45,11 +46,28 @@ public void init(final ByteBuffer buf, final int position)
public void aggregate(final ByteBuffer buf, final int position, final int
startRow, final int endRow)
{
final double[] vector = selector.getDoubleVector();
- for (int i = startRow; i < endRow; i++) {
- DoubleMeanHolder.update(buf, position, vector[i]);
+ final boolean[] nulls = selector.getNullVector();
+
+ if (nulls != null) {
+ if (NullHandling.replaceWithDefault()) {
Review comment:
I saw a case with testing on my local cluster and that's why had to make
this change. Let's leave this as is since it is safer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
