paul-rogers commented on pull request #12368:
URL: https://github.com/apache/druid/pull/12368#issuecomment-1080945084
This is a big PR. It is all-in-one so folks can see the whole picture. If it
helps, this can be broken into smaller chunks, at loss of overall context.
Here's a quick summary of what's new vs. what's refactored:
* `docker-tests/docs` is all new and is meant to capture all the learnings
from this exercise, along with information needed to move froward. This is the
main resource for understanding this PR.
* `docker-tests` project is new so it does not conflict with the existing
`integration-tests` project: both can exist.
* `docker-tests/base-test` is mostly new. It contains the revised test
config code and a new cluster client.
* `ClusterConfig` is the YAML-based config mechanism.
* `Initializer` has a bunch of complexity to force the server-minded Guice
config to work in a client. Loads the DB. Etc.
* `docker-tests/test-image` is a greatly refactored set of Docker build
scripts. The Dockerfile is heavily refactored to remove the third-party
dependencies and rearrange how Druid is laid out (unpacked from the
distribution tarball). DB setup is removed.
* `docker-tests/testing-tools` is mostly a copy/paste of
`extensions-core/testing-tools` with the custom node role from
`integration-tests` added.
* `docker-tests/high-availability` is a refactor of one test from
`integration-tests`. The Docker Compose script is specific to this one test,
refactored from those in `integration-tests`. The idea is that this test
contains just the files for this "group". Other groups will follow this pattern.
* Other files are mostly clean-up uncovered while debugging. In some cases,
code was refactored so the test "clients" could use code that was previously
tightly coupled with the server.
* `yaml` files: refactor of Docker Compose with new test config.
Also, as noted before, this PR moves authorization aside into separate
files. Authorization is not yet enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
