techdocsmith commented on a change in pull request #12371:
URL: https://github.com/apache/druid/pull/12371#discussion_r836992003
##########
File path: docs/ingestion/ingestion-spec.md
##########
@@ -205,7 +205,7 @@ A `dimensionsSpec` can have the following components:
| Field | Description
| Default |
|------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|
-| `dimensions` | A list of [dimension names or
objects](#dimension-objects). Cannot have the same column in both `dimensions`
and `dimensionExclusions`.<br><br>If this and `spatialDimensions` are both null
or empty arrays, Druid will treat all non-timestamp, non-metric columns that do
not appear in `dimensionExclusions` as String-typed dimension columns. See
[inclusions and exclusions](#inclusions-and-exclusions) below for details.
| `[]` |
+| `dimensions` | A list of [dimension names or
objects](#dimension-objects). Cannot have the same column in both `dimensions`
and `dimensionExclusions`.<br><br>If this and `spatialDimensions` are both null
or empty arrays, Druid will treat all non-timestamp, non-metric columns that do
not appear in `dimensionExclusions` as String-typed dimension columns. See
[inclusions and exclusions](#inclusions-and-exclusions) below for
details.<br><br>It is best practice to put the most frequently filtered
dimensions at the beginning of the dimensions list. In this case, it would also
be good to consider [`partitioning`](partitioning.md) by those same dimensions.
| `[]` |
Review comment:
```suggestion
| `dimensions` | A list of [dimension names or
objects](#dimension-objects). You cannot include the same column in both
`dimensions` and `dimensionExclusions`.<br><br>If `dimensions` and
`spatialDimensions` are both null or empty arrays, Druid treats all columns
other than timestamp or metrics that do not appear in `dimensionExclusions` as
String-typed dimension columns. See [inclusions and
exclusions](#inclusions-and-exclusions) for details.<br><br>As a best practice,
put the most frequently filtered dimensions at the beginning of the dimensions
list. In this case, it would also be good to consider
[`partitioning`](partitioning.md) by those same dimensions.
| `[]` |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
