clintropolis opened a new pull request #12378: URL: https://github.com/apache/druid/pull/12378
### Description This PR rebrands `ComplexMetricSerde` as `ComplexTypeSerde`, `ComplexMetrics` as `ComplexTypes`, and `ComplexMetricExtractor` as `ComplexTypeExtractor`. All of the former are marked as deprecated, and their logic moved to (and implement) the latter to minimize disruption. All current serdes still implement `ComplexMetricSerde` rather than the new type, to allow anything using `ComplexMetrics.getSerdeForType` to continue functioning until their future removal, at which point the implementations shall be moved to extend `ComplexTypeSerde` directly. Additionally, it adds a method to `ComplexTypeExtractor`, `coerceValue`, to use to allow `COMPLEX` types to coerce values to the appropriate type when read from a column value selector from `RowBasedColumnSelectorFactory`. This allows `COMPLEX` typed dimensions to perform value coercion, similar to the other use of the `extractValue` method when reading `COMPLEX` metrics for queries against `IncrementalIndex`. <hr> This PR has: - [ ] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
