FrankChen021 commented on a change in pull request #12373:
URL: https://github.com/apache/druid/pull/12373#discussion_r838054221
##########
File path:
core/src/main/java/org/apache/druid/guice/GuiceAnnotationIntrospector.java
##########
@@ -58,9 +58,9 @@ public Object findInjectableValueId(AnnotatedMember m)
if (m instanceof AnnotatedMethod) {
throw new IAE("Annotated methods don't work very well yet...");
}
- return Key.get(m.getGenericType());
+ return Key.get(m.getRawType());
Review comment:
I didn't see that `getType` was marked deprecated in 2.10 from the link
above. Instead `public final JavaType getType(TypeBindings bogus)` was marked
deprecated.
IMO, it's better to follow the javadoc the replace the deprecated API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
