clintropolis opened a new pull request #12382:
URL: https://github.com/apache/druid/pull/12382


   
   ### Description
   This PR rebrands `ComplexMetricSerde` as `ComplexTypeSerde`, 
`ComplexMetrics` as `ComplexTypes`, and `ComplexMetricExtractor` as 
`ComplexTypeExtractor`. All of the former are marked as deprecated, and their 
logic moved to (and implement) the latter to minimize disruption. All current 
serdes still implement `ComplexMetricSerde` rather than the new type, to allow 
anything using `ComplexMetrics.getSerdeForType` to continue functioning until 
their future removal, at which point the implementations shall be moved to 
extend `ComplexTypeSerde` directly.
   
   I tested that this change is minimally disruptive by doing some tests using 
extensions (datasketches specifically, for my complex types) built against the 
master branch without the changes in this PR, and everything was still 
functioning correctly as far as I can tell, so I think it should be relatively 
chill despite changing stuff marked `@ExtensionPoint`.
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to