didip commented on a change in pull request #12339:
URL: https://github.com/apache/druid/pull/12339#discussion_r841253444
##########
File path:
extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSourceConfig.java
##########
@@ -90,6 +91,24 @@ public boolean isCredentialsConfigured()
secretAccessKey != null;
}
+ @JsonIgnore
+ public boolean isAssumeRoleArnConfigured()
+ {
+ return assumeRoleArn != null && !assumeRoleArn.trim().isEmpty();
+ }
+
+ @JsonIgnore
+ public boolean isAssumeRoleArnEnvConfigured()
+ {
+ return
!System.getenv(SDKGlobalConfiguration.AWS_ROLE_ARN_ENV_VAR).trim().isEmpty();
Review comment:
Don't `SDKGlobalConfiguration.AWS_ROLE_ARN_ENV_VAR` and `System.getenv`
always return a string no matter what?
##########
File path:
extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSourceConfig.java
##########
@@ -90,6 +91,24 @@ public boolean isCredentialsConfigured()
secretAccessKey != null;
}
+ @JsonIgnore
+ public boolean isAssumeRoleArnConfigured()
+ {
+ return assumeRoleArn != null && !assumeRoleArn.trim().isEmpty();
+ }
+
+ @JsonIgnore
+ public boolean isAssumeRoleArnEnvConfigured()
+ {
+ return
!System.getenv(SDKGlobalConfiguration.AWS_ROLE_ARN_ENV_VAR).trim().isEmpty();
+ }
+
+ @JsonIgnore
+ public boolean isWebIdentityTokenEnvConfigured()
+ {
+ return
!System.getenv(SDKGlobalConfiguration.AWS_WEB_IDENTITY_ENV_VAR).trim().isEmpty();
Review comment:
Don't `SDKGlobalConfiguration.AWS_ROLE_ARN_ENV_VAR` and `System.getenv`
always return a string no matter what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
