Codegass opened a new issue, #12399: URL: https://github.com/apache/druid/issues/12399
## Description When I am running the test for [DataGenerator](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java), I noticed that some test cases in this test class don’t have any Assert from JUnit: * [testLazyZipf](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L424) * [testRealUniform](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L334) * [testNormal](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L291) * [testEnumerated](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L262) * [testZipf](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L207) * [testRoundedNormal](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L164) * [ testDiscreteUniform ](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L99) * [testSequential](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L49) These test cases are all using the [`printStuff`](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L529) function to print out the related information for manual verification. There is no JUnit Assert function in these test cases. Based on my understanding, these cases require manual checking of the printed information to verify whether the test cases pass or fail. Also, The [testIntervalBasedTimeGeneration()](https://github.com/apache/druid/blob/b86f2d4c2e935346d600e51b22403150ebd1501d/processing/src/test/java/org/apache/druid/segment/generator/DataGeneratorTest.java#L375) test case does not have print info. It's hard for new contributors to tell whether it passes or fails. I am curious about why these test cases are designed without Assert. And if adding the assert is helpful, I would be more than happy to try submit a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
