churromorales opened a new pull request, #12408:
URL: https://github.com/apache/druid/pull/12408

   ### Description
   
   Adds Zstandard compression library to `CompressionStrategy`
   
   Ran Druid benchmark vs lz4: 
https://gist.github.com/churromorales/0a580e03e69f6ca6c13001c2a9aab0e0
   
   One thing that I did not like about this patch is some tests use a 
HeapByteBuffer and call the compression codec, and the zstd requires a DBB as 
it calls out to the c-library and it is always good to avoid doing the copy.  
For those tests I checked in the `ZstdDecompressor` if the buffer was direct 
and if it wasn't i copied the contents into a dbb.  
   
   If there are any other solutions here on how to approach this please let me 
know.  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to