clintropolis commented on code in PR #12388:
URL: https://github.com/apache/druid/pull/12388#discussion_r847923889
##########
processing/src/main/java/org/apache/druid/query/filter/Filter.java:
##########
@@ -75,13 +77,13 @@ default ImmutableBitmap getBitmapIndex(BitmapIndexSelector
selector)
* with reasonable sacrifice of the accuracy.
* As a result, the estimated selectivity might be different from the exact
value.
*
- * @param indexSelector Object used to retrieve bitmap indexes
+ * @param indexSelector Object used to retrieve indexes
*
* @return an estimated selectivity ranging from 0 (filter selects no rows)
to 1 (filter selects all rows).
*
- * @see Filter#getBitmapIndex(BitmapIndexSelector)
+ * @see Filter#getBitmapIndex(ColumnIndexSelector)
*/
- double estimateSelectivity(BitmapIndexSelector indexSelector);
+ double estimateSelectivity(ColumnIndexSelector indexSelector);
Review Comment:
I didn't explicitly mention it, but I was opting to refactor selectivity
estimation as a follow-up change, since this was already pretty big, so I'd
prefer a follow-up I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
