jameskelleher opened a new pull request, #12432:
URL: https://github.com/apache/druid/pull/12432

   ### Description
   
   Fixes some errors in NOTES.txt when installing or upgrading with a 
`LoadBalancer` service.
   1. Add the namespace arg in two commands where it was missing
   2. Append `-router` to the end of the "fullnames".  For example, with a 
basic install/upgrade, `kubectl get svc --namespace dev -w druid` fails but 
`kubectl get svc --namespace dev -w druid-router` works as intended.
   3. Corrects the jsonpath search by changing `ip` to `hostname`.
   
   Given a basic installation that does not change the configuration too much, 
and assuming that the service changed to a `LoadBalancer` is the router, the 
commands in this section of the notes now work as intended.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   - [x] been self-reviewed.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to