[GitHub] [druid] abhishekrb19 commented on a diff in pull request #11634: Add IPAddress java library as dependency and migrate IPv4 functions to use the new library.

Tue, 12 Apr 2022 18:12:23 -0700 


abhishekrb19 commented on code in PR #11634:
URL: https://github.com/apache/druid/pull/11634#discussion_r848986676


##########
processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java:
##########
@@ -104,19 +105,21 @@ public ExprEval eval(final ObjectBinding bindings)
 
       private boolean isStringMatch(String stringValue)
       {
-        return IPv4AddressExprUtils.isValidAddress(stringValue) && 
subnetInfo.isInRange(stringValue);
+        IPv4Address iPv4Address = IPv4AddressExprUtils.parse(stringValue);

Review Comment:
   Yeah, I think IPv6 would be a separate class on its own. As things stand 
now, IPv4Address works well. We can perhaps revisit this when we have the IPv6 
functionality in place. :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to